Mistic Weapons v1.3

Version 1.3  Stability & Bug Fix Update

April 23, 2026

This update is a comprehensive internal overhaul focused entirely on stability, correctness, and performance. No new content has been added — every change is a fix to an existing system.

Critical Fixes

• Aetherius Blade — Rune system completely non-functional
  Rune data assigned on kill was never actually saved to the weapon. Each call to getItemMeta() returned a separate copy of the metadata, so all PDC writes were silently discarded. The rune effect system now works as intended.
• Vault Integration — Money duplication/loss on transfer
  When the Thief Sword or Repair Sword triggered an economy transfer, if the deposit() step failed after a successful withdraw(), the money was permanently lost from the source player without reaching the target. A rollback refund is now applied automatically on failure.

High Priority Fixes

• Vampire Sword & Poison Dagger — Thread safety crash risk
  Both abilities used standard HashMap for cooldown and stack tracking while a background ScheduledExecutorService accessed them concurrently. This is undefined behavior and could cause ConcurrentModificationException crashes. Switched to ConcurrentHashMap.
• Aetherius Blade & Elven Bow — Abilities reading from wrong config section
  Both abilities were reading ability parameters (damage, range, arrow count, spread angle, etc.) from the main config.yml using paths that don't exist there, instead of the correct weapon-specific YAML files. All ability values now load correctly.
• Teleport Bow — WorldGuard region bypass
  Players could use the Teleport Bow to teleport into WorldGuard-protected regions that they otherwise had no access to. A region check is now performed at the destination before any teleport is executed.
• Player quit causing all Trap Sword traps to despawn
  When any player disconnected from the server, the AbilityListener was calling trapSwordAbility.shutdown(), which cancelled every active trap from every player. Now only the quitting player's cleanup is handled.

Medium Priority Fixes

• Phantom Blade — Combo stacks accumulating on cancelled events
  The melee hit handler was not marked ignoreCancelled = true, meaning combos would build up even on hits that were blocked by other plugins or game mechanics.
• Explosive Bow — Memory leak from ricochet arrows
  Arrows that ricochet off walls were tracked in a HashMap but were never removed if they flew into the void or despawned naturally. Over time this would grow unbounded. Ricochet entries are now cleaned up after 60 seconds.
• Vampire Sword — Excessive scheduler usage during Blood Rage
  Each Blood Rage activation was scheduling 30 individual delayed tasks for the particle effect (one per tick). This has been replaced with a single looping BukkitRunnable, reducing scheduler pressure significantly.
• Aetherius Blade — Wrong feedback message on hit combo
  The empowerment combo counter was sending an incorrect message key to the player's action bar.

Low Priority Fixes

• Vampire Sword — Memory leak on player disconnect
  Player entries in the lifesteal cooldown map were never removed when a player logged off. Added proper cleanup on PlayerQuitEvent.
• Shadow Sword — Task cancellation race condition
  When re-activating Smoke Bomb, the new invisibility task was being scheduled before the old one was cancelled, creating a brief window where both ran simultaneously.
• Elven Bow — Incorrect ability display name
  getAbilityName() was returning the internal ID "elven_bow" instead of the display name "Elven Bow".
• AbilityManager — Dead code removed
  An identity switch statement that mapped every weapon ID to itself (e.g. "elven_bow" -> "elven_bow") was removed.

17 bugs fixed across 13 files. No API changes, no config changes required.

• ⚡ Lightning Bow - Chain lightning attacks
• Explosive Bow - Ricocheting explosive arrows
• Vampire Sword - Lifesteal and blood rage
• Shadow Sword - Stealth and backstab mechanics
• Poison Dagger - Stack-based poison system

• Discord: Join for support
• Bug Reports: GitHub Issues
• ✨ Feature Requests: Discord #suggestions channel
• ⚔️ Weapon Ideas: Share your creative concepts!